third_party/WebKit/Source/core/dom/ExecutionContext.h - Issue 1504403003: Calling isSecureContext() with no arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.h

Issue 1504403003: Calling isSecureContext() with no arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small refactoring to isSecureContext() calls Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ExecutionContext.h

diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.h b/third_party/WebKit/Source/core/dom/ExecutionContext.h

index 49b7e8f3d45a3c7cae986a649035245dcda88248..54bb45fea69a206a42279e82de781900bd98d8e2 100644

--- a/third_party/WebKit/Source/core/dom/ExecutionContext.h

+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.h

@@ -156,6 +156,7 @@ public:

// Decides whether this context is privileged, as described in

// https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged.

virtual bool isSecureContext(String& errorMessage, const SecureContextCheck = StandardSecureContextCheck) const = 0;

+ virtual bool isSecureContext(const SecureContextCheck = StandardSecureContextCheck) const;

virtual void setReferrerPolicy(ReferrerPolicy);

ReferrerPolicy referrerPolicy() const { return m_referrerPolicy; }