Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1504403003: Calling isSecureContext() with no arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactored isSecureContext() Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index 8c97a4c44930dab5518a0139b8bedaaf65f6f351..a32d61069ec02699b9ce721265eba8f5fb61f7cd 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -200,11 +200,7 @@ void Fullscreen::documentWasDisposed()
void Fullscreen::requestFullscreen(Element& element, RequestType requestType)
{
- // It is required by isSecureContext() but isn't
- // actually used. This could be used later if a warning is shown in the
- // developer console.
- String errorMessage;
- if (document()->isSecureContext(errorMessage)) {
+ if (document()->ExecutionContext::isSecureContext()) {
estark 2015/12/18 00:00:57 You should remove the "ExecutionContext::" qualifi
UseCounter::count(document(), UseCounter::FullscreenSecureOrigin);
} else {
UseCounter::count(document(), UseCounter::FullscreenInsecureOrigin);

Powered by Google App Engine
This is Rietveld 408576698