third_party/WebKit/Source/core/dom/Fullscreen.cpp - Issue 1504403003: Calling isSecureContext() with no arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1504403003: Calling isSecureContext() with no arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved isSecureContext() implementation to base class Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp

diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp

index 8c97a4c44930dab5518a0139b8bedaaf65f6f351..a32d61069ec02699b9ce721265eba8f5fb61f7cd 100644

--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp

+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp

@@ -200,11 +200,7 @@ void Fullscreen::documentWasDisposed()

void Fullscreen::requestFullscreen(Element& element, RequestType requestType)

{

- // It is required by isSecureContext() but isn't

- // actually used. This could be used later if a warning is shown in the

- // developer console.

- String errorMessage;

- if (document()->isSecureContext(errorMessage)) {

+ if (document()->ExecutionContext::isSecureContext()) {

UseCounter::count(document(), UseCounter::FullscreenSecureOrigin);

} else {

UseCounter::count(document(), UseCounter::FullscreenInsecureOrigin);