[turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64.

[turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64.

This operator now provides a second output which indicates whether the
conversion from float32 to int64 was successful or not. The second output
returns 0 if the conversion fails, or something else if the conversion succeeds.

The second output can be ignored, which means that the operator can be used the
same as the original operator.

I implement the new operator on x64, arm64, and mips64. @v8-ppc-ports, can you
please take care of the ppc64 implementation of the second output?

R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com

Committed: https://crrev.com/28261daa47d406d73e40bf4afba16ee61f300089
Cr-Commit-Position: refs/heads/master@{#32737}

[jbramley, 2015-12-08 13:53:08]

jacob.bramley@arm.com changed reviewers:
+ jacob.bramley@arm.com

[jbramley, 2015-12-08 13:53:08]

ARM64 bits lgtm (with one simple fix).

https://codereview.chromium.org/1504363002/diff/1/src/compiler/arm64/code-gen...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/1504363002/diff/1/src/compiler/arm64/code-gen...
src/compiler/arm64/code-generator-arm64.cc:1043: __
Fccmp(i.InputDoubleRegister(0), i.InputDoubleRegister(0), VFlag, vc);
InputFloat32Register, surely.

[ahaas, 2015-12-09 11:15:01]

https://codereview.chromium.org/1504363002/diff/1/src/compiler/arm64/code-gen...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/1504363002/diff/1/src/compiler/arm64/code-gen...
src/compiler/arm64/code-generator-arm64.cc:1043: __
Fccmp(i.InputDoubleRegister(0), i.InputDoubleRegister(0), VFlag, vc);
On 2015/12/08 at 13:53:08, jbramley wrote:
> InputFloat32Register, surely.

Done.

[ahaas, 2015-12-09 11:16:13]

Description was changed from

==========
[turbofan] Change TruncateFloat64ToUint64 to TryTruncateFloatToUint64.

This operator now provides a second output which indicates whether the
conversion from float32 to int64 was successful or not. The second output
returns 0 if the conversion fails, or something else if the conversion succeeds.

The second output can be ignored, which means that the operator can be used the
same as the original operator.

I implement the new operator on x64, arm64, and mips64. @v8-ppc-ports, can you
please take care of the ppc64 implementation of the second output?

R=titzer@chromium.org, v8-arm-ports@googlegroups.com,
v8-mips-ports@googlegroups.com
==========

to

==========
[turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64.

This operator now provides a second output which indicates whether the
conversion from float32 to int64 was successful or not. The second output
returns 0 if the conversion fails, or something else if the conversion succeeds.

The second output can be ignored, which means that the operator can be used the
same as the original operator.

I implement the new operator on x64, arm64, and mips64. @v8-ppc-ports, can you
please take care of the ppc64 implementation of the second output?

R=titzer@chromium.org, v8-arm-ports@googlegroups.com,
v8-mips-ports@googlegroups.com
==========

[titzer, 2015-12-09 11:40:21]

On 2015/12/09 11:15:01, ahaas wrote:
>
https://codereview.chromium.org/1504363002/diff/1/src/compiler/arm64/code-gen...
> File src/compiler/arm64/code-generator-arm64.cc (right):
> 
>
https://codereview.chromium.org/1504363002/diff/1/src/compiler/arm64/code-gen...
> src/compiler/arm64/code-generator-arm64.cc:1043: __
> Fccmp(i.InputDoubleRegister(0), i.InputDoubleRegister(0), VFlag, vc);
> On 2015/12/08 at 13:53:08, jbramley wrote:
> > InputFloat32Register, surely.
> 
> Done.

LGTM other than spurious case.

[titzer, 2015-12-09 11:40:35]

https://codereview.chromium.org/1504363002/diff/40001/src/compiler/mips64/ins...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1504363002/diff/40001/src/compiler/mips64/ins...
src/compiler/mips64/instruction-selector-mips64.cc:1543: case
IrOpcode::kTryTruncateFloat32ToInt64:
Drop this case as per explanation on other CL.

[ahaas, 2015-12-09 12:02:18]

On 2015/12/09 at 11:40:35, titzer wrote:
>
https://codereview.chromium.org/1504363002/diff/40001/src/compiler/mips64/ins...
> File src/compiler/mips64/instruction-selector-mips64.cc (right):
> 
>
https://codereview.chromium.org/1504363002/diff/40001/src/compiler/mips64/ins...
> src/compiler/mips64/instruction-selector-mips64.cc:1543: case
IrOpcode::kTryTruncateFloat32ToInt64:
> Drop this case as per explanation on other CL.

Done.

[ahaas, 2015-12-10 08:10:29]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2015-12-10 08:10:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jacob.bramley@arm.com, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1504363002/#ps60001
(title: "Removed bad code in the mips code")

[commit-bot: I haz the power, 2015-12-10 08:10:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504363002/60001

[commit-bot: I haz the power, 2015-12-10 08:12:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-10 08:12:33]

Description was changed from

==========
[turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64.

This operator now provides a second output which indicates whether the
conversion from float32 to int64 was successful or not. The second output
returns 0 if the conversion fails, or something else if the conversion succeeds.

The second output can be ignored, which means that the operator can be used the
same as the original operator.

I implement the new operator on x64, arm64, and mips64. @v8-ppc-ports, can you
please take care of the ppc64 implementation of the second output?

R=titzer@chromium.org, v8-arm-ports@googlegroups.com,
v8-mips-ports@googlegroups.com
==========

to

==========
[turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64.

This operator now provides a second output which indicates whether the
conversion from float32 to int64 was successful or not. The second output
returns 0 if the conversion fails, or something else if the conversion succeeds.

The second output can be ignored, which means that the operator can be used the
same as the original operator.

I implement the new operator on x64, arm64, and mips64. @v8-ppc-ports, can you
please take care of the ppc64 implementation of the second output?

R=titzer@chromium.org, v8-arm-ports@googlegroups.com,
v8-mips-ports@googlegroups.com

Committed: https://crrev.com/28261daa47d406d73e40bf4afba16ee61f300089
Cr-Commit-Position: refs/heads/master@{#32737}
==========

[commit-bot: I haz the power, 2015-12-10 08:12:34]

Patchset 4 (id:??) landed as
https://crrev.com/28261daa47d406d73e40bf4afba16ee61f300089
Cr-Commit-Position: refs/heads/master@{#32737}