CFI: blacklist wtf::Vector that sometimes casts garbage data.

CFI: blacklist wtf::Vector that sometimes casts garbage data.

BUG=568891
Committed: https://crrev.com/2db5d15849e6d7a0dcfb01f3b7aa10ecbeea6bee
Cr-Commit-Position: refs/heads/master@{#364625}

[krasin, 2015-12-11 03:52:35]

krasin@google.com changed reviewers:
+ pcc@google.com

[pcc1, 2015-12-11 04:17:46]

I assume you've considered e.g. making VectorBufferBase::m_buffer [1] a void*
and fixing the fallout. If so, lgtm

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[krasin, 2015-12-11 04:39:01]

On 2015/12/11 04:17:46, pcc1 wrote:
> I assume you've considered e.g. making VectorBufferBase::m_buffer [1] a void*
> and fixing the fallout. If so, lgtm
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Positive. I've considered doing that. It goes pretty hairy, as it requires to
change allocateVectorBacking and related stuff:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

In fact, after second thought, I have decided to blacklist
wtf/PartitionAllocator.h too. I don't see any test failures regarding to that
file, but I would not like to have it as the next reason to rollback the CFI
launch CL.

[krasin, 2015-12-11 04:39:44]

The CQ bit was checked by krasin@google.com

[krasin, 2015-12-11 04:39:44]

The patchset sent to the CQ was uploaded after l-g-t-m from pcc@chromium.org
Link to the patchset: https://codereview.chromium.org/1504333012/#ps20001
(title: "wtf/PartitionAllocator.h")

[commit-bot: I haz the power, 2015-12-11 04:40:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504333012/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504333012/20001

[commit-bot: I haz the power, 2015-12-11 06:13:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-11 06:13:50]

Description was changed from

==========
CFI: blacklist wtf::Vector that sometimes casts garbage data.

BUG=568891
==========

to

==========
CFI: blacklist wtf::Vector that sometimes casts garbage data.

BUG=568891

Committed: https://crrev.com/2db5d15849e6d7a0dcfb01f3b7aa10ecbeea6bee
Cr-Commit-Position: refs/heads/master@{#364625}
==========

[commit-bot: I haz the power, 2015-12-11 06:13:51]

Patchset 2 (id:??) landed as
https://crrev.com/2db5d15849e6d7a0dcfb01f3b7aa10ecbeea6bee
Cr-Commit-Position: refs/heads/master@{#364625}