Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1504333002: Remove special handling of xpointer( as fragment url (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
fs
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove special handling of xpointer( as fragment url Unless we're implementing xpointer( real soon now, we might as well be honest about not supporting it. BUG=567693 Committed: https://crrev.com/5652cb50efdfea174b00fe624ea4e72be1044a25 Cr-Commit-Position: refs/heads/master@{#363787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504333002/1
5 years ago (2015-12-08 10:56:54 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/116979)
5 years ago (2015-12-08 11:14:34 UTC) #4
davve
I thought I should bounce this off the bots before passing along but the bots ...
5 years ago (2015-12-08 11:23:01 UTC) #6
fs
On 2015/12/08 at 11:23:01, davve wrote: > I thought I should bounce this off the ...
5 years ago (2015-12-08 12:11:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504333002/1
5 years ago (2015-12-08 20:25:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 21:43:34 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-08 21:44:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5652cb50efdfea174b00fe624ea4e72be1044a25
Cr-Commit-Position: refs/heads/master@{#363787}

Powered by Google App Engine
This is Rietveld 408576698