Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1504313005: fix a couple flaky nonnull attribute ubsan warnings (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M include/core/SkTypes.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504313005/1
5 years ago (2015-12-09 17:13:13 UTC) #4
mtklein_C
5 years ago (2015-12-09 17:18:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 17:36:28 UTC) #8
herb_g
lgtm
5 years ago (2015-12-09 18:00:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504313005/1
5 years ago (2015-12-09 18:01:40 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-09 18:02:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/02046c50b294ae2b28e562b0e6e281e4ef823352

Powered by Google App Engine
This is Rietveld 408576698