Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1504313003: Fix mismatched parenthesis error message (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix mismatched parenthesis error message 'file:xxxx.dart': error: line 2 pos 4: unterminated '(' foo(state { // <= missing closing parenthesis ^ Also include a couple of postscripts from previous change. BUG=5830 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/d68a7de36a18db3da3ac92731d19a1592983effb

Patch Set 1 #

Patch Set 2 : Add fixes from previous CL review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/object.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
hausner
5 years ago (2015-12-08 22:37:39 UTC) #4
Ivan Posva
LGTM -ip
5 years ago (2015-12-08 23:20:02 UTC) #5
hausner
5 years ago (2015-12-08 23:36:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d68a7de36a18db3da3ac92731d19a1592983effb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698