Add support for LayerTreeSettings (de)serialization

Add support for LayerTreeSettings (de)serialization

As part of serializing cc::LayerTreeHost, we also need to
serialize the cc::LayerTreeSettings.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2fe752c3c8b169b515990c2cb189805836adfcd2
Cr-Commit-Position: refs/heads/master@{#364452}

[nyquist, 2015-12-08 02:01:07]

Description was changed from

==========
Add support for LayerTreeSettings (de)serialization

As part of serializing cc::LayerTreeHost, we also need to
serialize the cc::LayerTreeSettings.

BUG=561210
==========

to

==========
Add support for LayerTreeSettings (de)serialization

As part of serializing cc::LayerTreeHost, we also need to
serialize the cc::LayerTreeSettings.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[nyquist, 2015-12-08 02:01:42]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2015-12-08 02:02:09]

nyquist@chromium.org changed reviewers:
+ vmpstr@chromium.org

[nyquist, 2015-12-08 02:02:10]

vmpstr: PTAL
dtrainor: FYI

[commit-bot: I haz the power, 2015-12-08 02:03:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504273002/1

[commit-bot: I haz the power, 2015-12-08 03:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 03:20:19]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[vmpstr, 2015-12-08 18:26:13]

https://codereview.chromium.org/1504273002/diff/1/cc/proto/layer_tree_setting...
File cc/proto/layer_tree_settings.proto (right):

https://codereview.chromium.org/1504273002/diff/1/cc/proto/layer_tree_setting...
cc/proto/layer_tree_settings.proto:37: 
Remove the blank line please

https://codereview.chromium.org/1504273002/diff/1/cc/proto/layer_tree_setting...
cc/proto/layer_tree_settings.proto:73: 
Here as well?

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
File cc/trees/layer_tree_settings.cc (right):

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:33: NOTREACHED() << "Sending
proto::LayerTreeSettings_ScrollbarAnimator_UNKNOWN";
nit: s/Sending // 

I'd like to avoid language that suggests that this is only for over the network
processing.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:49: << "Received
proto::LayerTreeSettings_ScrollbarAnimator_UNKNOWN";
nit: s/Received //

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:163: other.use_image_texture_targets.size() && 
// See below.
std::vector has operator==, you can just compare the two vectors.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:236: for (auto u : use_image_texture_targets)
can you put this at the end with a blank line before?

also, auto? it's just an unsigned...

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:303: for (int i = 0; i <
proto.use_image_texture_targets_size(); i++)
Can you put this at the end with a blank line before

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_settings.h
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:88: bool operator==(const LayerTreeSettings&
other) const;
Can you put these above all of the variables. Also, while here can you put
ToSchedulerSettings above as well?

[nyquist, 2015-12-08 22:44:58]

vmpstr: PTAL

https://codereview.chromium.org/1504273002/diff/1/cc/proto/layer_tree_setting...
File cc/proto/layer_tree_settings.proto (right):

https://codereview.chromium.org/1504273002/diff/1/cc/proto/layer_tree_setting...
cc/proto/layer_tree_settings.proto:37: 
On 2015/12/08 18:26:13, vmpstr wrote:
> Remove the blank line please

Done.

https://codereview.chromium.org/1504273002/diff/1/cc/proto/layer_tree_setting...
cc/proto/layer_tree_settings.proto:73: 
On 2015/12/08 18:26:13, vmpstr wrote:
> Here as well?

Done.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
File cc/trees/layer_tree_settings.cc (right):

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:33: NOTREACHED() << "Sending
proto::LayerTreeSettings_ScrollbarAnimator_UNKNOWN";
On 2015/12/08 18:26:13, vmpstr wrote:
> nit: s/Sending // 
> 
> I'd like to avoid language that suggests that this is only for over the
network
> processing.

Done.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:49: << "Received
proto::LayerTreeSettings_ScrollbarAnimator_UNKNOWN";
On 2015/12/08 18:26:13, vmpstr wrote:
> nit: s/Received //

Done.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:163: other.use_image_texture_targets.size() && 
// See below.
On 2015/12/08 18:26:13, vmpstr wrote:
> std::vector has operator==, you can just compare the two vectors.

Done.
Also; I'm sorry, because this messed up the diff since now I could just remove
the whole equals-variable, and instead just return the result.
If you can see the inline diff though, it's just the indent that's different on
all the other lines. I just did you you said, removed the last part of the
function, and changed the top to just return instead of declaring equals.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:236: for (auto u : use_image_texture_targets)
On 2015/12/08 18:26:13, vmpstr wrote:
> can you put this at the end with a blank line before?
> 
> also, auto? it's just an unsigned...

Done.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.cc:303: for (int i = 0; i <
proto.use_image_texture_targets_size(); i++)
On 2015/12/08 18:26:13, vmpstr wrote:
> Can you put this at the end with a blank line before

Done.

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_settings.h
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/1504273002/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:88: bool operator==(const LayerTreeSettings&
other) const;
On 2015/12/08 18:26:13, vmpstr wrote:
> Can you put these above all of the variables. Also, while here can you put
> ToSchedulerSettings above as well?

Done.

[vmpstr, 2015-12-10 00:51:24]

lgtm with nits

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
File cc/trees/layer_tree_settings.cc (right):

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
cc/trees/layer_tree_settings.cc:309: for (int i = 0; i <
proto.use_image_texture_targets_size(); i++)
++i

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
File cc/trees/layer_tree_settings_unittest.cc (right):

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
cc/trees/layer_tree_settings_unittest.cc:26: TEST(LayerTreeSettingsTest,
AllMembersFlipped) {
nit: s/Flipped/Changed/

[nyquist, 2015-12-10 01:22:57]

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
File cc/trees/layer_tree_settings.cc (right):

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
cc/trees/layer_tree_settings.cc:309: for (int i = 0; i <
proto.use_image_texture_targets_size(); i++)
On 2015/12/10 00:51:24, vmpstr wrote:
> ++i

Done.

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
File cc/trees/layer_tree_settings_unittest.cc (right):

https://codereview.chromium.org/1504273002/diff/20001/cc/trees/layer_tree_set...
cc/trees/layer_tree_settings_unittest.cc:26: TEST(LayerTreeSettingsTest,
AllMembersFlipped) {
On 2015/12/10 00:51:24, vmpstr wrote:
> nit: s/Flipped/Changed/

Done.

[nyquist, 2015-12-10 01:23:03]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-12-10 01:23:04]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1504273002/#ps60001
(title: "rebased onto origin/master")

[commit-bot: I haz the power, 2015-12-10 01:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504273002/60001

[commit-bot: I haz the power, 2015-12-10 01:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 01:35:46]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[nyquist, 2015-12-10 18:40:33]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2015-12-10 18:42:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504273002/60001

[commit-bot: I haz the power, 2015-12-10 20:12:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-10 20:14:28]

Description was changed from

==========
Add support for LayerTreeSettings (de)serialization

As part of serializing cc::LayerTreeHost, we also need to
serialize the cc::LayerTreeSettings.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add support for LayerTreeSettings (de)serialization

As part of serializing cc::LayerTreeHost, we also need to
serialize the cc::LayerTreeSettings.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2fe752c3c8b169b515990c2cb189805836adfcd2
Cr-Commit-Position: refs/heads/master@{#364452}
==========

[commit-bot: I haz the power, 2015-12-10 20:14:29]

Patchset 4 (id:??) landed as
https://crrev.com/2fe752c3c8b169b515990c2cb189805836adfcd2
Cr-Commit-Position: refs/heads/master@{#364452}