Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1504233002: add suggestion for partial named parameter - fixes #24758 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add suggestion for partial named parameter - fixes #24758 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/20909182b08803336a609acddfc5a28e83cff894

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 2 chunks +18 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
5 years ago (2015-12-07 21:59:08 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1504233002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart File pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart (right): https://codereview.chromium.org/1504233002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart#newcode98 pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart:98: if (entity.offset <= offset && offset < entity.offset ...
5 years ago (2015-12-07 22:07:28 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as 20909182b08803336a609acddfc5a28e83cff894 (presubmit successful).
5 years ago (2015-12-07 22:13:10 UTC) #5
danrubel
5 years ago (2015-12-07 22:13:36 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1504233002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart
(right):

https://codereview.chromium.org/1504233002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart:98:
if (entity.offset <= offset && offset < entity.offset + entity.length) {
On 2015/12/07 22:07:28, scheglov wrote:
> FYI, there is also AstNode.end getter.

Good suggestion. Done.

https://codereview.chromium.org/1504233002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
(right):

https://codereview.chromium.org/1504233002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart:15:
import 'package:analyzer/src/generated/ast.dart';
On 2015/12/07 22:07:28, scheglov wrote:
> sort

Oops. Forgot. Done.

Powered by Google App Engine
This is Rietveld 408576698