Move Document::m_inStyleRecalc into DocumentLifecycle

Move Document::m_inStyleRecalc into DocumentLifecycle

This CL removes the m_inStyleRecalc bool from Document and adds that
information to the DocumentLifecycle state machine. We eventually want to move
style recalc, layout, compositing update, and paiting into the state machine.

BUG=282720
R=eseidel@chromium.org, vollick@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166187

[eseidel, 2014-01-31 01:54:21]

we disagree if "Clean" is the first or last state of active.  But otherwise
lgtm.

https://codereview.chromium.org/150423004/diff/1/Source/core/dom/DocumentLife...
File Source/core/dom/DocumentLifecycle.h (right):

https://codereview.chromium.org/150423004/diff/1/Source/core/dom/DocumentLife...
Source/core/dom/DocumentLifecycle.h:46: Attached,
I would call this "clean" or something similar and move it to teh bottom.  We
jump right from "inactive" to "Clean" if necessary, as we progress through the
update steps we get cleaner and cleaner until we're "Clean".

[Ian Vollick, 2014-01-31 01:57:03]

On 2014/01/31 01:54:21, eseidel wrote:
> we disagree if "Clean" is the first or last state of active.  But otherwise
> lgtm.
> 
>
https://codereview.chromium.org/150423004/diff/1/Source/core/dom/DocumentLife...
> File Source/core/dom/DocumentLifecycle.h (right):
> 
>
https://codereview.chromium.org/150423004/diff/1/Source/core/dom/DocumentLife...
> Source/core/dom/DocumentLifecycle.h:46: Attached,
> I would call this "clean" or something similar and move it to teh bottom.  We
> jump right from "inactive" to "Clean" if necessary, as we progress through the
> update steps we get cleaner and cleaner until we're "Clean".

lgtm2. I'm with Eric on the Clean verbiage. Having an assert like ASSERT(the
document is clean) will be a lot easier to wrap your head around. :)

[abarth-chromium, 2014-01-31 02:05:32]

I renamed the state to Clean, but I didn't move it to the end.  I'll move it to
the end in the next CL.

We talked this out, and we think there are two separate operations:

1) advanceTo, which always moves forward in the state machine.  You can
advanceTo(Clean), which means Clean needs to be at the end (at least before
Stopping).

2) rewindTo, which always move backwards in the state machine.  The rewind
function is used when state becomes dirty, so you can rewind to needing to do a
style recalc.

I'll make all that happen in the next CL when I move m_hasPendingStyleRecalc
into the state machine.

[abarth-chromium, 2014-01-31 02:05:50]

On 2014/01/31 01:57:03, Ian Vollick wrote:
> lgtm2. I'm with Eric on the Clean verbiage. Having an assert like ASSERT(the
> document is clean) will be a lot easier to wrap your head around. :)

Done

[commit-bot: I haz the power, 2014-01-31 02:08:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/150423004/20001

[commit-bot: I haz the power, 2014-01-31 05:09:16]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-01-31 05:09:18]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 05:09:24]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 05:22:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/150423004/20001

[abarth-chromium, 2014-01-31 06:00:05]

Committed patchset #2 manually as r166187 (presubmit successful).

[commit-bot: I haz the power, 2014-01-31 06:00:07]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 06:00:16]

CQ bit was unchecked on CL. Ignoring.