Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1504223005: extract TypeMemberContributor from prefixed element contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

extract TypeMemberContributor from prefixed element contributor R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e03c395a8c5c08e9ef8d6118f29a142db22e7928

Patch Set 1 #

Patch Set 2 : delete unused code #

Total comments: 1

Patch Set 3 : mege #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4637 lines, -1437 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 1 chunk +448 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +1 line, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 1 chunk +0 lines, -369 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 3 chunks +0 lines, -362 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +5 lines, -28 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 1 chunk +4157 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 chunk +0 lines, -673 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-09 02:41:53 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1504223005/diff/20001/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart File pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart (right): https://codereview.chromium.org/1504223005/diff/20001/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart#newcode116 pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:116: _objectType = coreLib.getType('Object').type; This code can throw NPE. ...
5 years ago (2015-12-09 04:49:20 UTC) #3
danrubel
5 years ago (2015-12-09 12:38:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
e03c395a8c5c08e9ef8d6118f29a142db22e7928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698