Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 15042009: Update tests to use FileCheck instead of grep (which is deprecated in the LLVM regression suite) (Closed)

Created:
7 years, 7 months ago by eliben
Modified:
7 years, 7 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Update tests to use FileCheck instead of grep (which is deprecated in the LLVM regression suite) BUG=None R=mseaborn@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=c5d1983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M test/Transforms/NaCl/expand-ctors.ll View 1 chunk +4 lines, -3 lines 0 comments Download
M test/Transforms/NaCl/expand-ctors-empty.ll View 1 chunk +3 lines, -2 lines 0 comments Download
M test/Transforms/NaCl/expand-ctors-zeroinit.ll View 1 chunk +3 lines, -2 lines 0 comments Download
M test/Transforms/NaCl/expand-tls.ll View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eliben
Hi Mark, Usage of grep is deprecated for LLVM regression tests and FileCheck has to ...
7 years, 7 months ago (2013-05-14 21:49:24 UTC) #1
Mark Seaborn
LGTM
7 years, 7 months ago (2013-05-14 22:05:45 UTC) #2
eliben
7 years, 7 months ago (2013-05-14 22:07:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rc5d1983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698