Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 150413009: Make prev and next pointer in pages list AtomicWords and access them using acquire/release semantic… (Closed)

Created:
6 years, 10 months ago by Hannes Payer (out of office)
Modified:
6 years, 10 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Make prev and next pointer in pages list AtomicWords and access them using acquire/release semantics. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19332

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M src/spaces.h View 1 2 6 chunks +24 lines, -9 lines 0 comments Download
M src/spaces.cc View 1 2 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
6 years, 10 months ago (2014-02-12 12:41:28 UTC) #1
Jarin
lgtm with a nit. https://codereview.chromium.org/150413009/diff/30001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685 src/spaces.h:685: AtomicWord prev_chunk_; Perhaps it would ...
6 years, 10 months ago (2014-02-12 14:06:39 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685 src/spaces.h:685: AtomicWord prev_chunk_; On 2014/02/12 14:06:39, jarin wrote: > Perhaps ...
6 years, 10 months ago (2014-02-12 15:33:19 UTC) #3
Hannes Payer (out of office)
Committed patchset #3 manually as r19332 (presubmit successful).
6 years, 10 months ago (2014-02-12 15:40:30 UTC) #4
Jarin
6 years, 10 months ago (2014-02-12 15:43:32 UTC) #5
Message was sent while issue was closed.
On 2014/02/12 15:33:19, Hannes Payer wrote:
> https://codereview.chromium.org/150413009/diff/30001/src/spaces.h
> File src/spaces.h (right):
> 
> https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685
> src/spaces.h:685: AtomicWord prev_chunk_;
> On 2014/02/12 14:06:39, jarin wrote:
> > Perhaps it would be better to add a comment describing the type of the
> > AtomicWords (i.e., MemoryChunk*). 
> > 
> > Should not next_chunk_ and prev_chunk_ be private?
> 
> Done.

lgtm.

thanks, ship it!

Powered by Google App Engine
This is Rietveld 408576698