Issue 150413005: Support escaped char codes in WebVTT tokenizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150413005: Support escaped char codes in WebVTT tokenizer. (Closed)

Created:
6 years, 10 months ago by Anjali

Modified:
6 years, 10 months ago

Reviewers:
gasubic, acolwell GONE FROM CHROMIUM, philipj_slow, damienv1, abarth-chromium

CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Support escaped char codes in WebVTT tokenizer. Escaped char codes for example '&#233' show up literally instead of the character they represent. This CL adds support for escaped chars. BUG=340341

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	Source/core/html/track/vtt/VTTTokenizer.cpp	View		3 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Not LGTM, since this is not per spec: http://dev.w3.org/html5/webvtt/ We considered this in https://www.w3.org/Bugs/Public/show_bug.cgi?id=23867 but ...

6 years, 10 months ago (2014-02-05 18:52:27 UTC) #2

philipj_slow

Anjali, if you could comment here or in the spec bug what prompted you to ...

6 years, 10 months ago (2014-02-06 08:50:18 UTC) #3

Anjali

This came up as a partner bug. I have asked them if there is a ...

6 years, 10 months ago (2014-02-06 17:09:28 UTC) #4

Anjali

6 years, 10 months ago (2014-02-12 22:36:11 UTC) #5

Closing this issue for now. We can re-open it once this is added to the spec.

Expand Messages | Collapse Messages