content/browser/android/content_view_core_impl.cc - Issue 15041004: Replace PruneAllButActive with PruneAllButVisible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 15041004: Replace PruneAllButActive with PruneAllButVisible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update tests, mark TODOs Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 8bc6e47463906dcfc287eb06b0ea0342c0aaf3d0..ee8f7a713fecb0dcff97bcf2b1b6e34b7d94cd07 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -1182,7 +1182,9 @@ void ContentViewCoreImpl::ContinuePendingReload(JNIEnv* env, jobject obj) {

}

void ContentViewCoreImpl::ClearHistory(JNIEnv* env, jobject obj) {

- web_contents_->GetController().PruneAllButActive();

+ // TODO(creis): Do callers of this need to know if it fails?

+ if (web_contents_->GetController().CanPruneAllButVisible())

+ web_contents_->GetController().PruneAllButVisible();

}

void ContentViewCoreImpl::AddJavascriptInterface(