Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1504093003:
Remove usage of deprecated APIs from heap profiler tests (Closed)
|
Created:
5 years ago by jochen (gone - plz use gerrit) Modified:
5 years ago Reviewers:
vogelheim CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionRemove usage of deprecated APIs from heap profiler tests
BUG=v8:4134
R=vogelheim@chromium.org
LOG=n
NOTRY=true
NOPRESUBMIT=true
Committed: https://crrev.com/2ad36975109b09b45d2ae1c55c23b03933d1470e
Cr-Commit-Position: refs/heads/master@{#32677}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
lgtm
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504093003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/382)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504093003/1
The CQ bit was unchecked by jochen@chromium.org
Description was changed from ========== Remove usage of deprecated APIs from heap profiler tests BUG=v8:4134 R=vogelheim@chromium.org LOG=n ========== to ========== Remove usage of deprecated APIs from heap profiler tests BUG=v8:4134 R=vogelheim@chromium.org LOG=n NOTRY=true ==========
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504093003/1
The CQ bit was unchecked by jochen@chromium.org
Description was changed from ========== Remove usage of deprecated APIs from heap profiler tests BUG=v8:4134 R=vogelheim@chromium.org LOG=n NOTRY=true ========== to ========== Remove usage of deprecated APIs from heap profiler tests BUG=v8:4134 R=vogelheim@chromium.org LOG=n NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504093003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove usage of deprecated APIs from heap profiler tests BUG=v8:4134 R=vogelheim@chromium.org LOG=n NOTRY=true NOPRESUBMIT=true ========== to ========== Remove usage of deprecated APIs from heap profiler tests BUG=v8:4134 R=vogelheim@chromium.org LOG=n NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/2ad36975109b09b45d2ae1c55c23b03933d1470e Cr-Commit-Position: refs/heads/master@{#32677} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2ad36975109b09b45d2ae1c55c23b03933d1470e Cr-Commit-Position: refs/heads/master@{#32677} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
