Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1504073002:
fuzzer for WebSocketFrameParser (Closed)
Descriptionfuzzer for WebSocketFrameParser
R=inferno@chromium.org
TBR=krasin@chromium.org
BUG=566504
Committed: https://crrev.com/1622efb4e4c04a6957011665ddf4b7568cdf5d1f
Cr-Commit-Position: refs/heads/master@{#363686}
Patch Set 1 #
Total comments: 1
Patch Set 2 : rename fuzzer and remove redundant header/dep #
Messages
Total messages: 21 (10 generated)
inferno@chromium.org changed reviewers: + aizatsky@chromium.org, krasin@chromium.org
aizatsky@chromium.org: Please review changes in krasin@chromium.org: Please review changes in
krasin@google.com changed reviewers: + krasin@google.com
lgtm
inferno@chromium.org changed reviewers: - krasin@google.com
lgtm with nits. https://codereview.chromium.org/1504073002/diff/1/testing/libfuzzer/fuzzers/B... File testing/libfuzzer/fuzzers/BUILD.gn (right): https://codereview.chromium.org/1504073002/diff/1/testing/libfuzzer/fuzzers/B... testing/libfuzzer/fuzzers/BUILD.gn:246: test("websocket_frame_fuzzer") { nit: websocket_frame_parser_fuzzer to match unittest names. same for all the filename websocket_frame_parser_fuzzer.cc
On 2015/12/07 17:48:41, inferno wrote: > https://codereview.chromium.org/1504073002/diff/1/testing/libfuzzer/fuzzers/B... > testing/libfuzzer/fuzzers/BUILD.gn:246: test("websocket_frame_fuzzer") { > nit: websocket_frame_parser_fuzzer to match unittest names. same for all the > filename websocket_frame_parser_fuzzer.cc Thanks, will fix that. Also <stdint.h> is redundant header there.
The CQ bit was checked by inferno@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from krasin@google.com Link to the patchset: https://codereview.chromium.org/1504073002/#ps20001 (title: "rename fuzzer and remove redundant header/dep")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504073002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== fuzzer for WebSocketFrameParser R=inferno@chromium.org BUG=566504 ========== to ========== fuzzer for WebSocketFrameParser R=inferno@chromium.org TBR=krasin@chromium.org BUG=566504 ==========
The CQ bit was checked by aarya@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504073002/20001
Message was sent while issue was closed.
Description was changed from ========== fuzzer for WebSocketFrameParser R=inferno@chromium.org TBR=krasin@chromium.org BUG=566504 ========== to ========== fuzzer for WebSocketFrameParser R=inferno@chromium.org TBR=krasin@chromium.org BUG=566504 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== fuzzer for WebSocketFrameParser R=inferno@chromium.org TBR=krasin@chromium.org BUG=566504 ========== to ========== fuzzer for WebSocketFrameParser R=inferno@chromium.org TBR=krasin@chromium.org BUG=566504 Committed: https://crrev.com/1622efb4e4c04a6957011665ddf4b7568cdf5d1f Cr-Commit-Position: refs/heads/master@{#363686} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1622efb4e4c04a6957011665ddf4b7568cdf5d1f Cr-Commit-Position: refs/heads/master@{#363686} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
