Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1504043002:
Ignore zero-length joins (Closed)
DescriptionZero length lines may have caps, but do not need joins.
Check to see if the point is preceeded or followed
by a line with a computable tangent before adding the join.
R=reed@google.com
BUG=566075
Committed: https://skia.googlesource.com/skia/+/57eecc154e20b454ad2f889049670fe386f038da
Patch Set 1 #Patch Set 2 : ignore zero-move pts if preceeded or followed by tangents #Patch Set 3 : track whether prior join was completed #Patch Set 4 : let has_valid_tangent work with exhausted iter #Messages
Total messages: 24 (12 generated)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== experiment to see if exact stroke iterator affects any gm Zero length lines are considered as part of the stroke. Try ignoring them to see if it causes other tests to fail. BUG=566075 ========== to ========== Zero length lines may have caps, but do not need joins. Check to see if the point is preceeded or followed by a line with a computable tangent before adding the join. R=reed@google.com BUG=566075 ==========
caryclark@google.com changed reviewers: + reed@google.com
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504043002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504043002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504043002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by caryclark@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504043002/60001
Message was sent while issue was closed.
Description was changed from ========== Zero length lines may have caps, but do not need joins. Check to see if the point is preceeded or followed by a line with a computable tangent before adding the join. R=reed@google.com BUG=566075 ========== to ========== Zero length lines may have caps, but do not need joins. Check to see if the point is preceeded or followed by a line with a computable tangent before adding the join. R=reed@google.com BUG=566075 Committed: https://skia.googlesource.com/skia/+/57eecc154e20b454ad2f889049670fe386f038da ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/57eecc154e20b454ad2f889049670fe386f038da |
