Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/clang/plugins/tests/inline_ctor.h

Issue 1504033010: Follow macro invocations when checking if a violation happened in a .cc file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/inline_ctor.h
diff --git a/tools/clang/plugins/tests/inline_ctor.h b/tools/clang/plugins/tests/inline_ctor.h
index 1ab1589c87979f473a94710afbdb31ca48e65140..811e978ed7a17f2adf16b08251752f2ca8ea3e07 100644
--- a/tools/clang/plugins/tests/inline_ctor.h
+++ b/tools/clang/plugins/tests/inline_ctor.h
@@ -18,6 +18,18 @@ class InlineCtorsArentOKInHeader {
std::vector<std::string> two_;
};
+#define INLINE_CTORS_IN_A_MACRO(CLASS_NAME) \
+ class CLASS_NAME { \
+ public: \
+ CLASS_NAME() {} \
+ ~CLASS_NAME() {} \
+ \
+ private: \
+ std::vector<int> one_; \
+ std::vector<std::string> two_; \
+ }
+INLINE_CTORS_IN_A_MACRO(InlineCtorsBehindAMacroArentOKInHeader);
+
class DeletedMembersInHeaderAreOKThough {
public:
DeletedMembersInHeaderAreOKThough() = delete;

Powered by Google App Engine
This is Rietveld 408576698