Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2272)

Unified Diff: content/browser/storage_partition_impl.cc

Issue 1504033007: Move Indexed DB from dedicated thread to task scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timer
Patch Set: Tweak traits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/indexed_db/indexed_db_transaction.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/storage_partition_impl.cc
diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc
index dbea3089dcedd5db9aadf7a77f1ca91fa4c4a054..5c4270512f9614eafefc00b3d70723b7c9f8f3cd 100644
--- a/content/browser/storage_partition_impl.cc
+++ b/content/browser/storage_partition_impl.cc
@@ -15,6 +15,7 @@
#include "base/sequenced_task_runner.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/task_scheduler/post_task.h"
#include "content/browser/blob_storage/chrome_blob_storage_context.h"
#include "content/browser/browser_main_loop.h"
#include "content/browser/browsing_data/storage_partition_http_cache_data_remover.h"
@@ -473,14 +474,18 @@ std::unique_ptr<StoragePartitionImpl> StoragePartitionImpl::Create(
// BrowserMainLoop may not be initialized in unit tests. Tests will
// need to inject their own task runner into the IndexedDBContext.
- base::SequencedTaskRunner* idb_task_runner =
+ // TODO(jsbell): This is no longer true, update tests to provide use a
+ // base::test::ScopedTaskEnvironment instead of injecting a test task
+ // runner.
+ scoped_refptr<base::SequencedTaskRunner> idb_task_runner =
BrowserThread::CurrentlyOn(BrowserThread::UI) &&
BrowserMainLoop::GetInstance()
- ? BrowserMainLoop::GetInstance()
- ->indexed_db_thread()
- ->task_runner()
- .get()
- : NULL;
+ ? base::CreateSequencedTaskRunnerWithTraits({
+ base::MayBlock(), base::WithBaseSyncPrimitives(),
+ base::TaskPriority::USER_VISIBLE,
+ base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN,
+ })
+ : nullptr;
base::FilePath path = in_memory ? base::FilePath() : partition_path;
partition->indexed_db_context_ =
« no previous file with comments | « content/browser/indexed_db/indexed_db_transaction.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698