Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.cpp

Issue 1504013004: GC plugin: remove mixin trace override restriction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/RecordInfo.cpp
diff --git a/tools/clang/blink_gc_plugin/RecordInfo.cpp b/tools/clang/blink_gc_plugin/RecordInfo.cpp
index cf7fb8c578e80ed3e4b6c1f78e83260e1848dda2..3c166dd4c431374f32ff2851d01654c82d7a805a 100644
--- a/tools/clang/blink_gc_plugin/RecordInfo.cpp
+++ b/tools/clang/blink_gc_plugin/RecordInfo.cpp
@@ -365,26 +365,6 @@ bool RecordInfo::DeclaresLocalTraceMethod() {
return is_declaring_local_trace_;
}
-bool RecordInfo::IsGCMixinInstance() {
- assert(IsGCDerived());
- if (record_->isAbstract())
- return false;
-
- assert(!IsGCMixin());
-
- // true iff the class derives from GCMixin and
- // one or more other GC base classes.
- bool seen_gc_mixin = false;
- bool seen_gc_derived = false;
- for (const auto& gc_base : gc_base_names_) {
- if (Config::IsGCMixinBase(gc_base))
- seen_gc_mixin = true;
- else if (Config::IsGCBase(gc_base))
- seen_gc_derived = true;
- }
- return seen_gc_derived && seen_gc_mixin;
-}
-
// A (non-virtual) class is considered abstract in Blink if it has
// no public constructors and no create methods.
bool RecordInfo::IsConsideredAbstract() {
« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.h ('k') | tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698