Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1503993002: Don't early return on SubtreeStyleChange for scheduling invalidations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-clear-invalidation-set-20151207
Patch Set: Rebased Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index 17ffeb754ca828d3b439e4155d0ae70d9d4d1300..575b315200c86f5f591b7e574ae3f19c22bd5757 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -1208,7 +1208,7 @@ void Element::attributeChanged(const QualifiedName& name, const AtomicString& ol
AtomicString newId = makeIdForStyleResolution(newValue, document().inQuirksMode());
if (newId != oldId) {
elementData()->setIdForStyleResolution(newId);
- if (inActiveDocument() && styleResolver && styleChangeType() < SubtreeStyleChange)
+ if (inActiveDocument() && styleResolver)
document().styleEngine().idChangedForElement(oldId, newId, *this);
}
} else if (name == classAttr) {
@@ -1288,7 +1288,7 @@ static inline ClassStringContent classStringHasClassName(const AtomicString& new
void Element::classAttributeChanged(const AtomicString& newClassString)
{
StyleResolver* styleResolver = document().styleResolver();
- bool testShouldInvalidateStyle = inActiveDocument() && styleResolver && styleChangeType() < SubtreeStyleChange;
+ bool testShouldInvalidateStyle = inActiveDocument() && styleResolver;
ASSERT(elementData());
ClassStringContent classStringContentType = classStringHasClassName(newClassString);
@@ -1877,7 +1877,7 @@ void Element::pseudoStateChanged(CSSSelector::PseudoType pseudo)
if (document().inStyleRecalc())
return;
StyleResolver* styleResolver = document().styleResolver();
- if (inActiveDocument() && styleResolver && styleChangeType() < SubtreeStyleChange)
+ if (inActiveDocument() && styleResolver)
document().styleEngine().pseudoStateChangedForElement(pseudo, *this);
}
@@ -2074,8 +2074,6 @@ void Element::checkForEmptyStyleChange()
if (!style && !styleAffectedByEmpty())
return;
- if (styleChangeType() >= SubtreeStyleChange)
- return;
if (!inActiveDocument())
return;
if (!document().styleResolver())
@@ -3133,7 +3131,7 @@ void Element::willModifyAttribute(const QualifiedName& name, const AtomicString&
}
if (oldValue != newValue) {
- if (inActiveDocument() && document().styleResolver() && styleChangeType() < SubtreeStyleChange)
+ if (inActiveDocument() && document().styleResolver())
document().styleEngine().attributeChangedForElement(name, *this);
if (isUpgradedCustomElement())
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698