[Interpreter] Adds wide variant of CreateLiterals. Adds CreateLiterals to BytecodeGraphBuilder.

[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and CreateRegExpLiteral
to bytecode graph builder. Also changes these bytecodes to expect three operands instead of using
accumulator to pass one of the operands. This is done to avoid looking into the earlier nodes to
fetch operands in the bytecode graph builder. Also adds support for wide variant of these
bytecodes to bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/67c99a991829fdf81169e3a51163ee23f21082df
Cr-Commit-Position: refs/heads/master@{#32710}

[mythria, 2015-12-07 10:38:27]

Description was changed from

==========
[Interpreter] Adds support for CreateLiterals to bytecode graph builder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral
and CreateRegExpLiteral to bytecode graph builder. Also changes these
bytecodes to expect operands explicitly instead of using accumulator. This
is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Adds support for CreateLiterals to bytecode graph builder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral
and CreateRegExpLiteral to bytecode graph builder. Also changes these
bytecodes to expect three operands instead of using accumulator to pass one of
the operands. This
is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder.

BUG=v8:4280
LOG=N
==========

[mythria, 2015-12-07 10:39:57]

mythria@chromium.org changed reviewers:
+ bmeurer@chromium.org, oth@chromium.org, rmcilroy@chromium.org

[mythria, 2015-12-07 10:39:57]

Could you please review my changes.

Thanks,
Mythri

[rmcilroy, 2015-12-07 14:33:22]

https://codereview.chromium.org/1503963002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1503963002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:710: iterator.GetImmediateOperand(2),
iterator.GetIndexOperand(1));
Could you pull out the iterator.GetXXX() to named local variables so that it is
more clear what is being passed to each parameter here (also for the visitors
below).

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:538: } else {
Are you adding wide variants in this CL or a subsequent one?

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:548: size_t cons_element_entry =
GetConstantPoolEntry(constant_elements);
don't abbreviate (cons_element_entry -> constant_elements_entry)

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:564: size_t cons_property_entry =
GetConstantPoolEntry(constant_properties);
ditto

[mythria, 2015-12-07 14:46:31]

Description was changed from

==========
[Interpreter] Adds support for CreateLiterals to bytecode graph builder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral
and CreateRegExpLiteral to bytecode graph builder. Also changes these
bytecodes to expect three operands instead of using accumulator to pass one of
the operands. This
is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Adds support for CreateLiterals to bytecode graph builder. Adds
support for wide variant of CreateLiterals to bytecode generator.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral to bytecode graph builder. Also changes these bytecodes to
expect three operands instead of using accumulator to pass one of the operands.
This is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder. Also adds support for wide variant of these bytecodes to
bytecode generator. 

BUG=v8:4280
LOG=N
==========

[mythria, 2015-12-07 15:11:18]

I added wide variants to bytecode generator and addressed review comments. Could
you please take a look.

Thanks,
Mythri

https://codereview.chromium.org/1503963002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1503963002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:710: iterator.GetImmediateOperand(2),
iterator.GetIndexOperand(1));
On 2015/12/07 14:33:22, rmcilroy wrote:
> Could you pull out the iterator.GetXXX() to named local variables so that it
is
> more clear what is being passed to each parameter here (also for the visitors
> below). 

Done.

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:538: } else {
On 2015/12/07 14:33:22, rmcilroy wrote:
> Are you adding wide variants in this CL or a subsequent one?

Added wide variants with patchset2.

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:548: size_t cons_element_entry =
GetConstantPoolEntry(constant_elements);
On 2015/12/07 14:33:22, rmcilroy wrote:
> don't abbreviate (cons_element_entry -> constant_elements_entry)

Done.

https://codereview.chromium.org/1503963002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:564: size_t cons_property_entry =
GetConstantPoolEntry(constant_properties);
On 2015/12/07 14:33:22, rmcilroy wrote:
> ditto

Done.

[oth, 2015-12-07 16:47:29]

lgtm

[rmcilroy, 2015-12-08 10:03:09]

lgtm

[Benedikt Meurer, 2015-12-09 07:24:12]

LGTM(compiler) with comment

https://codereview.chromium.org/1503963002/diff/60001/src/compiler/bytecode-g...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1503963002/diff/60001/src/compiler/bytecode-g...
src/compiler/bytecode-graph-builder.cc:707: Node* closure =
GetFunctionClosure();
This code is duplicated 3 times. How about adding a helper and pass in the
operator?

[mythria, 2015-12-09 09:41:32]

Description was changed from

==========
[Interpreter] Adds support for CreateLiterals to bytecode graph builder. Adds
support for wide variant of CreateLiterals to bytecode generator.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral to bytecode graph builder. Also changes these bytecodes to
expect three operands instead of using accumulator to pass one of the operands.
This is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder. Also adds support for wide variant of these bytecodes to
bytecode generator. 

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral to bytecode graph builder. Also changes these bytecodes to
expect three operands instead of using accumulator to pass one of the operands.
This is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder. Also adds support for wide variant of these bytecodes to
bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N
==========

[mythria, 2015-12-09 09:42:15]

Description was changed from

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral to bytecode graph builder. Also changes these bytecodes to
expect three operands instead of using accumulator to pass one of the operands.
This is done to avoid looking into the earlier nodes to fetch operands in the
bytecode graph builder. Also adds support for wide variant of these bytecodes to
bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral
to bytecode graph builder. Also changes these bytecodes to expect three operands
instead of using
accumulator to pass one of the operands. This is done to avoid looking into the
earlier nodes to
fetch operands in the bytecode graph builder. Also adds support for wide variant
of these
bytecodes to bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N
==========

[mythria, 2015-12-09 09:48:20]

Thanks for your reviews. I added a BuildCreateLiteral helper function.

Thanks,
Mythri

https://codereview.chromium.org/1503963002/diff/60001/src/compiler/bytecode-g...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1503963002/diff/60001/src/compiler/bytecode-g...
src/compiler/bytecode-graph-builder.cc:707: Node* closure =
GetFunctionClosure();
On 2015/12/09 07:24:11, Benedikt Meurer wrote:
> This code is duplicated 3 times. How about adding a helper and pass in the
> operator?

Done.

[mythria, 2015-12-09 11:51:10]

The CQ bit was checked by mythria@chromium.org

[mythria, 2015-12-09 11:51:10]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
rmcilroy@chromium.org, bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1503963002/#ps100001
(title: "renamed BuildLiteral to BuildCreateLiteral.")

[commit-bot: I haz the power, 2015-12-09 11:51:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503963002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503963002/100001

[commit-bot: I haz the power, 2015-12-09 11:53:10]

Description was changed from

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral
to bytecode graph builder. Also changes these bytecodes to expect three operands
instead of using
accumulator to pass one of the operands. This is done to avoid looking into the
earlier nodes to
fetch operands in the bytecode graph builder. Also adds support for wide variant
of these
bytecodes to bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral
to bytecode graph builder. Also changes these bytecodes to expect three operands
instead of using
accumulator to pass one of the operands. This is done to avoid looking into the
earlier nodes to
fetch operands in the bytecode graph builder. Also adds support for wide variant
of these
bytecodes to bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2015-12-09 11:53:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-12-09 11:53:20]

Description was changed from

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral
to bytecode graph builder. Also changes these bytecodes to expect three operands
instead of using
accumulator to pass one of the operands. This is done to avoid looking into the
earlier nodes to
fetch operands in the bytecode graph builder. Also adds support for wide variant
of these
bytecodes to bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter]  Adds wide variant of CreateLiterals. Adds CreateLiterals to
BytecodeGraphBuilder.

Adds implementation and tests for CreateObjectLiteral, CreateArrayLiteral and
CreateRegExpLiteral
to bytecode graph builder. Also changes these bytecodes to expect three operands
instead of using
accumulator to pass one of the operands. This is done to avoid looking into the
earlier nodes to
fetch operands in the bytecode graph builder. Also adds support for wide variant
of these
bytecodes to bytecode generator and bytecode graph builder.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/67c99a991829fdf81169e3a51163ee23f21082df
Cr-Commit-Position: refs/heads/master@{#32710}
==========

[commit-bot: I haz the power, 2015-12-09 11:53:21]

Patchset 6 (id:??) landed as
https://crrev.com/67c99a991829fdf81169e3a51163ee23f21082df
Cr-Commit-Position: refs/heads/master@{#32710}