Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java

Issue 1503943003: [Cronet] Unit test refactoring and fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed changes related to CronetHttpURLConnection tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
index bd22a6ddc26056642d82ef604690ac9b5246a509..cc4ee7e6a0535e7a7db36c70a1bca30878fa64d0 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
@@ -27,6 +27,7 @@ public class CronetTestBase extends AndroidTestCase {
protected void setUp() throws Exception {
super.setUp();
PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX, getContext());
+ CronetTestFramework.prepareTestStorage(getContext());
}
/**
@@ -114,6 +115,31 @@ public class CronetTestBase extends AndroidTestCase {
}
}
+ /**
+ * Registers test host resolver for testing with the new API.
+ */
+ protected void registerHostResolver(CronetTestFramework framework) {
+ registerHostResolver(framework, false);
+ }
+
+ /**
+ * Registers test host resolver.
+ *
+ * @param isLegacyAPI true if the test should use the legacy API.
+ */
+ protected void registerHostResolver(CronetTestFramework framework, boolean isLegacyAPI) {
+ long urlRequestContextAdapter;
+ if (isLegacyAPI) {
+ urlRequestContextAdapter = ((ChromiumUrlRequestFactory) framework.mRequestFactory)
+ .getRequestContext()
+ .getUrlRequestContextAdapter();
+ } else {
+ urlRequestContextAdapter = ((CronetUrlRequestContext) framework.mCronetEngine)
+ .getUrlRequestContextAdapter();
+ }
+ NativeTestServer.registerHostResolverProc(urlRequestContextAdapter, isLegacyAPI);
+ }
+
@Target(ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
public @interface CompareDefaultWithCronet {

Powered by Google App Engine
This is Rietveld 408576698