Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1503943002: X87: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder. port 086d4598473fe25b6b8f802998d6e85e90625136 (r32644) original commit message: The backing store is only held alive indirectly via the array buffer referenced by the holder (typed array), so it's not enough to keep the elements alive (or even just the external pointer loaded from the elements). BUG= Committed: https://crrev.com/5837db4171aba5339decccea797b555774e8ec74 Cr-Commit-Position: refs/heads/master@{#32648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/crankshaft/x87/lithium-x87.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 08:59:56 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 09:10:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503943002/1
5 years ago (2015-12-07 09:10:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 09:44:36 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 09:45:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5837db4171aba5339decccea797b555774e8ec74
Cr-Commit-Position: refs/heads/master@{#32648}

Powered by Google App Engine
This is Rietveld 408576698