Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2943)

Unified Diff: build/android/adb_install_apk.py

Issue 1503933003: [Android] Make adb_install_apk.py support multiple specific devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_install_apk.py
diff --git a/build/android/adb_install_apk.py b/build/android/adb_install_apk.py
index a816bd403f8cc5c13d589728b10f20e3416b7d32..2d1ec33dd4e7fe94120d4aa9b7cd4be21a5b13e0 100755
--- a/build/android/adb_install_apk.py
+++ b/build/android/adb_install_apk.py
@@ -51,8 +51,9 @@ def main():
dest='build_type',
help='If set, run test suites under out/Release. '
'Default is env var BUILDTYPE or Debug.')
- parser.add_argument('-d', '--device', dest='device',
- help='Target device for apk to install on.')
+ parser.add_argument('-d', '--device', dest='devices', action='append',
+ help='Target device for apk to install on. Enter multiple'
+ ' times for multiple devices.')
parser.add_argument('--blacklist-file', help='Device blacklist JSON file.')
parser.add_argument('-v', '--verbose', action='count',
help='Enable verbose logging.')
@@ -88,10 +89,10 @@ def main():
else None)
devices = device_utils.DeviceUtils.HealthyDevices(blacklist)
- if args.device:
- devices = [d for d in devices if d == args.device]
+ if args.devices:
+ devices = [d for d in devices if d in args.devices]
if not devices:
- raise device_errors.DeviceUnreachableError(args.device)
+ raise device_errors.DeviceUnreachableError(args.devices)
elif not devices:
raise device_errors.NoDevicesError()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698