Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1503933003: [Android] Make adb_install_apk.py support multiple specific devices (Closed)

Created:
5 years ago by rnephew (Reviews Here)
Modified:
5 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make adb_install_apk.py support multiple specific devices Currently, only 1 or all devices can be installed form one invocation. This changes allows for multiple devices to be specified. BUG=514449 Committed: https://crrev.com/1f4f32555e00e0cd72e40fd78080c61339fcc87d Cr-Commit-Position: refs/heads/master@{#363637}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M build/android/adb_install_apk.py View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rnephew (Reviews Here)
5 years ago (2015-12-07 21:39:14 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/1503933003/diff/1/build/android/adb_install_apk.py File build/android/adb_install_apk.py (right): https://codereview.chromium.org/1503933003/diff/1/build/android/adb_install_apk.py#newcode54 build/android/adb_install_apk.py:54: parser.add_argument('-d', '--device', dest='device', action='append', nit: dest ...
5 years ago (2015-12-07 21:40:54 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/1503933003/diff/1/build/android/adb_install_apk.py File build/android/adb_install_apk.py (right): https://codereview.chromium.org/1503933003/diff/1/build/android/adb_install_apk.py#newcode54 build/android/adb_install_apk.py:54: parser.add_argument('-d', '--device', dest='device', action='append', On 2015/12/07 21:40:54, jbudorick wrote: ...
5 years ago (2015-12-07 21:47:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503933003/20001
5 years ago (2015-12-07 21:50:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-08 00:46:57 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-08 00:48:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f4f32555e00e0cd72e40fd78080c61339fcc87d
Cr-Commit-Position: refs/heads/master@{#363637}

Powered by Google App Engine
This is Rietveld 408576698