Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1503923002: X87: [fullcode] Switch passing of new.target to register. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcode] Switch passing of new.target to register. port 440a42b74135b84c188d7db11f4c07678f53d0f3 (r32548) original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. Note that this marks the last consumer of said side-channel and the special slot in the construct stub frame can be removed as a follow-up. BUG= Committed: https://crrev.com/e3b1cf17263325d47c467f018c0c474af66eb3cd Cr-Commit-Position: refs/heads/master@{#32635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -37 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +26 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 02:34:00 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 02:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503923002/1
5 years ago (2015-12-07 02:51:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 03:24:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 03:24:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b1cf17263325d47c467f018c0c474af66eb3cd
Cr-Commit-Position: refs/heads/master@{#32635}

Powered by Google App Engine
This is Rietveld 408576698