Enable meta-based validation for shared libraries.

src/trusted/service_runtime/nacl_syscall_common.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * NaCl service run-time, non-platform specific system call helper routines.
  */
 #include <sys/types.h>
@@ skipping 1500 matching lines @@
        * For eventual munmap, stopping threads also involve looking at
        * their registers to make sure their %rip/%eip/%ip are not
        * inside the region being modified (impossible for initial
        * insertion).  This is needed because mmap->munmap->mmap could
        * cause problems due to scheduler races.
        *
        * Use NaClDynamicRegionCreate to mark region as allocated.
        */
       uintptr_t image_sys_addr;
       NaClValidationStatus validator_status = NaClValidationFailed;
+      struct NaClValidationMetadata metadata;
       int sys_ret;  /* syscall return convention */
       int ret;
 
       NaClLog(4, "NaClSysMmap: checking descriptor type\n");
       if (NACL_VTBL(NaClDesc, ndp)->typeTag != NACL_DESC_HOST_IO) {
         NaClLog(4, "NaClSysMmap: not supported type, got %d\n",
                 NACL_VTBL(NaClDesc, ndp)->typeTag);
         map_result = -NACL_ABI_EINVAL;
         goto cleanup;
       }
@@ skipping 16 matching lines @@
                              (void *) NULL,
                              length,
                              NACL_ABI_PROT_READ | NACL_ABI_PROT_WRITE,
                              NACL_ABI_MAP_PRIVATE,
                              offset);
       if (NaClPtrIsNegErrno(&image_sys_addr)) {
         map_result = image_sys_addr;
         goto cleanup;
       }
 
-      /*
-       * TODO(bsy): when ncbray provides validation cache metadata
-       * interface, plumb this through here. We need to extract the
-       * descriptor metadata as a bag of bits via NACL_VTBL(NaClDesc,
-       * ndp)->GetMetadata(...), possibly deserialize its contents
-       * using a validation cache provided function into a struct
-       * NaClValidationMetadata object, and pass it through here, as
-       * well as destroying the metadata object etc.
-       */
-
       /* Ask validator / validation cache */
+      MetadataFromNaClDescCtor(&metadata, ndp);
       validator_status = NACL_FI("MMAP_FORCE_MMAP_VALIDATION_FAIL",
                                  (*nap->validator->
                                   Validate)(usraddr,
                                             (uint8_t *) image_sys_addr,
                                             length,
                                             0,  /* stubout_mode: no */
                                             1,  /* readonly_text: yes */
                                             nap->cpu_features,
-                                            NULL,  /* metadata */
+                                            &metadata,
                                             nap->validation_cache),
                                  NaClValidationFailed);
       NaClLog(3, "NaClSysMmap: prot_exec, validator_status %d\n",
               validator_status);
+      MetadataDtor(&metadata);
 
       if (NaClValidationSucceeded == validator_status) {
         /*
          * Check if target address range is actually available.  It
          * must be neither in use by NaClText interface, nor used by
          * previous mmap'd code.  We record mmap'd code regions in the
          * NaClText's data structures to avoid lo both having to deal
          * with looking in two data structures.  We could do this
          * first since this is a cheaper check, but it shouldn't
          * matter since application errors ought to be rare and we
@@ skipping 1952 matching lines @@
   return NaClSysClockGetCommon(natp, clk_id, (uintptr_t) tsp,
                                      NaClClockGetRes);
 }
 
 int32_t NaClSysClockGetTime(struct NaClAppThread  *natp,
                             int                   clk_id,
                             uint32_t              tsp) {
   return NaClSysClockGetCommon(natp, clk_id, (uintptr_t) tsp,
                                      NaClClockGetTime);
 }