Add the ability to use AllowAddressReuse for UDP sockets.

chrome/browser/extensions/api/socket/udp_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/udp_socket.h"
 
 #include <algorithm>
 
 #include "chrome/browser/extensions/api/api_resource.h"
 #include "net/base/ip_endpoint.h"
@@ skipping 225 matching lines @@
                   normalized_address);
   if (find_result != multicast_groups_.end())
     return net::ERR_ADDRESS_INVALID;
 
   int rv = socket_.JoinGroup(ip);
   if (rv == 0)
     multicast_groups_.push_back(normalized_address);
   return rv;
 }
 
+int UDPSocket::AllowAddressReuse() {
+  if (socket_.is_connected()) {
+    return net::ERR_UNEXPECTED;
+  }
+  socket_.AllowAddressReuse();
+  return net::OK;

[mmenke, 2013/05/24 21:12:00]

I think "return 0;" is actually more consistent with the rest of these two
files, particularly since the caller compares the result directly with 0, not
net::OK.

Ideally, I think a lot of the 0 comparisons should be checking against net::OK,
but changing that is beyond the scoope of this CL.

[Noam Samuel, 2013/05/24 21:43:53]

Done.

+}
+
 int UDPSocket::LeaveGroup(const std::string& address) {
   net::IPAddressNumber ip;
   if (!net::ParseIPLiteralToNumber(address, &ip))
     return net::ERR_ADDRESS_INVALID;
 
   std::string normalized_address = net::IPAddressToString(ip);
   std::vector<std::string>::iterator find_result =
       std::find(multicast_groups_.begin(),
                 multicast_groups_.end(),
                 normalized_address);
@@ skipping 12 matching lines @@
 
 int UDPSocket::SetMulticastLoopbackMode(bool loopback) {
   return socket_.SetMulticastLoopbackMode(loopback);
 }
 
 const std::vector<std::string>& UDPSocket::GetJoinedGroups() const {
   return multicast_groups_;
 }
 
 }  // namespace extensions