[Memory Sheriff] --top-symbols for waterfall match

[Memory Sheriff] --top-symbols for waterfall match

Allow "--top-symbols <n>" as an argument for "waterfall match".

Will list the top <n> symbol occurrences in all unsuppressed reports.

NOTRY=true
R=thestig@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198813

[Lei Zhang, 2013-05-07 20:39:55]

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
File tools/valgrind/test_suppressions.py (right):

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:6: import argparse
Is everyone running an OS on their desktop with Python 2.7 these days? I
certainly hope so.

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:61: assert len(demangled) == len(names)+1
style nit: spaces around +

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:70: symbols.append(line[index+4:])
index + len('fun:'), or have some constant that indicate where 4 came from.

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:75: boring_symbols=['malloc', '_Znw*',
'TestBody']
Use BoringCallers() in common.py?

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:82: symboltable =
dict(zip(symbols,demangled))
style nit: space after comma.

[groby-ooo-7-16, 2013-05-07 20:57:59]

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
File tools/valgrind/test_suppressions.py (right):

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:6: import argparse
Seems to be the case.
On 2013/05/07 20:39:56, Lei Zhang wrote:
> Is everyone running an OS on their desktop with Python 2.7 these days? I
> certainly hope so.

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:61: assert len(demangled) == len(names)+1
On 2013/05/07 20:39:56, Lei Zhang wrote:
> style nit: spaces around +

Done.

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:70: symbols.append(line[index+4:])
On 2013/05/07 20:39:56, Lei Zhang wrote:
> index + len('fun:'), or have some constant that indicate where 4 came from.

Done.

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:75: boring_symbols=['malloc', '_Znw*',
'TestBody']
BoringCallers ignores different boringness. Per offline discussion, leaving this
instead of amending BoringCallers
On 2013/05/07 20:39:56, Lei Zhang wrote:
> Use BoringCallers() in common.py?

https://codereview.chromium.org/15039007/diff/1/tools/valgrind/test_suppressi...
tools/valgrind/test_suppressions.py:82: symboltable =
dict(zip(symbols,demangled))
On 2013/05/07 20:39:56, Lei Zhang wrote:
> style nit: space after comma.

Done.

[Lei Zhang, 2013-05-07 21:02:04]

lgtm

https://codereview.chromium.org/15039007/diff/5001/tools/valgrind/test_suppre...
File tools/valgrind/test_suppressions.py (right):

https://codereview.chromium.org/15039007/diff/5001/tools/valgrind/test_suppre...
tools/valgrind/test_suppressions.py:53: args = ['c++filt','-n']
more spaces after commas

[groby-ooo-7-16, 2013-05-07 21:43:34]

https://codereview.chromium.org/15039007/diff/5001/tools/valgrind/test_suppre...
File tools/valgrind/test_suppressions.py (right):

https://codereview.chromium.org/15039007/diff/5001/tools/valgrind/test_suppre...
tools/valgrind/test_suppressions.py:53: args = ['c++filt','-n']
On 2013/05/07 21:02:04, Lei Zhang wrote:
> more spaces after commas

Done.

[commit-bot: I haz the power, 2013-05-07 21:49:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/15039007/8001

[commit-bot: I haz the power, 2013-05-07 22:14:52]

Change committed as 198813