Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503893002: Add more (incomplete) diagnostic support to the status pages (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more (incomplete) diagnostic support to the status pages R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1101a1e0e775868c671ce74f6915afb2b310336b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2046 lines, -104 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 18 chunks +248 lines, -104 lines 2 comments Download
A pkg/analysis_server/lib/src/status/validator.dart View 1 chunk +1787 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
5 years ago (2015-12-06 20:43:53 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1503893002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1503893002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode1179 pkg/analysis_server/lib/src/status/get_handler.dart:1179: buffer.write(iterator.key.toString()); The runtimeType is also interesting.
5 years ago (2015-12-07 06:19:29 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1503893002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1503893002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode1179 pkg/analysis_server/lib/src/status/get_handler.dart:1179: buffer.write(iterator.key.toString()); Done
5 years ago (2015-12-07 16:03:25 UTC) #4
Brian Wilkerson
5 years ago (2015-12-07 17:50:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1101a1e0e775868c671ce74f6915afb2b310336b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698