Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1503633002:
add md5sum device bin for x86 to dependencies (Closed)
|
Created:
5 years ago by bpastene Modified:
5 years ago Reviewers:
jbudorick CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionadd md5sum device bin to dependencies
BUG=
Committed: https://crrev.com/5fd5a83c2d1d693c2255ed1ee78c8e39cb2bcf5c
Cr-Commit-Position: refs/heads/master@{#363358}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add x86 to devil_chromium.py #
Messages
Total messages: 25 (9 generated)
bpastene@chromium.org changed reviewers: + jbudorick@chromium.org
ptal The hash of the md5sum bin is a sha1 sum >.<
https://codereview.chromium.org/1503633002/diff/1/build/android/devil/devil_d... File build/android/devil/devil_dependencies.json (right): https://codereview.chromium.org/1503633002/diff/1/build/android/devil/devil_d... build/android/devil/devil_dependencies.json:80: "android_x86": { ro.product.cpu.abi comes back with just "x86"?
https://codereview.chromium.org/1503633002/diff/1/build/android/devil/devil_d... File build/android/devil/devil_dependencies.json (right): https://codereview.chromium.org/1503633002/diff/1/build/android/devil/devil_d... build/android/devil/devil_dependencies.json:80: "android_x86": { On 2015/12/04 21:59:36, jbudorick wrote: > ro.product.cpu.abi comes back with just "x86"? [ro.product.cpu.abi]: [x86] [ro.product.cpu.abilist32]: [x86] [ro.product.cpu.abilist64]: [] [ro.product.cpu.abilist]: [x86] I think a lot of the properties are manually set by the android-cloud team, since they don't make a lot of sense on gce machines.
lgtm
On 2015/12/04 22:11:32, jbudorick wrote: > lgtm actually, add x86 to forwarder_device and md5sum_device in devil_chromium.py, too
On 2015/12/04 22:19:30, jbudorick wrote: > On 2015/12/04 22:11:32, jbudorick wrote: > > lgtm > > actually, add x86 to forwarder_device and md5sum_device in devil_chromium.py, > too good?
lgtm
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503633002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503633002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503633002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503633002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== add md5sum device bin to dependencies BUG= ========== to ========== add md5sum device bin to dependencies BUG= Committed: https://crrev.com/5fd5a83c2d1d693c2255ed1ee78c8e39cb2bcf5c Cr-Commit-Position: refs/heads/master@{#363358} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5fd5a83c2d1d693c2255ed1ee78c8e39cb2bcf5c Cr-Commit-Position: refs/heads/master@{#363358} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
