Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 150363002: Roll GTM to 626. (Closed)

Created:
6 years, 10 months ago by justincohen
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai, blundell
CC:
chromium-reviews, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll GTM to 626. This roll fixes the -Wdeprecated-declarations and -Wenum-conversion warnings on iOS builds. r626 Update the line break mode to use the updated constant, NSLineBreakByClipping, instead of UILineBreakModeClip r625 Fix up some assertions so that they don't run into issues with format strings not being constants. r624 Fix up build breakage on older compilers in GTMScriptRunner.m r623 Edited wiki page iPhoneUnitTesting through web user interface. r622 Edited wiki page iPhoneUnitTesting through web user interface. r621 Fix for GTMScriptRunner:run:standardError: deadlocks with full error pipe r620 Adding support for unit tests using ARC. r619 Fix up some compiler warnings. r618 Turn on three warnings that were on in Pulse but not on for local development. r617 Deprecate GTMObjectSingleton for 10.9/iOS 7 to force removal of the dependency from projects using it. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251840

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/google_toolbox_for_mac/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
justincohen
6 years, 10 months ago (2014-01-30 14:09:50 UTC) #1
blundell
It would be good to provide the one-line descriptions of the CLs being captured.
6 years, 10 months ago (2014-01-30 14:11:18 UTC) #2
justincohen
Updated!
6 years, 10 months ago (2014-01-30 14:14:33 UTC) #3
Mark Mentovai
LGTM
6 years, 10 months ago (2014-01-30 14:36:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/150363002/1
6 years, 10 months ago (2014-01-30 14:41:00 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 15:41:50 UTC) #6
justincohen
The CQ bit was checked by justincohen@chromium.org
6 years, 10 months ago (2014-02-18 17:24:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/150363002/20001
6 years, 10 months ago (2014-02-18 17:24:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/150363002/20001
6 years, 10 months ago (2014-02-18 18:22:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/150363002/20001
6 years, 10 months ago (2014-02-18 18:30:59 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 21:08:25 UTC) #11
Message was sent while issue was closed.
Change committed as 251840

Powered by Google App Engine
This is Rietveld 408576698