Add transfer buffer to GLCaps

Add transfer buffer to GLCaps

Adds a check for PBO/transfer buffer support to GrGLCaps,
and uses that to pick the correct buffer type.

BUG=skia:4604
Committed: https://skia.googlesource.com/skia/+/d7a2c1f5fd710581d6233de5c202d3f2627948e0

[jvanverth1, 2015-12-04 21:26:02]

Description was changed from

==========
Add transfer buffer to GLCaps

BUG=skia:4604
==========

to

==========
Add transfer buffer to GLCaps

Adds a check for PBO/transfer buffer support to GrGLCaps,
and uses that to pick the correct buffer type.

BUG=skia:4604
==========

[jvanverth1, 2015-12-04 21:39:52]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com

[jvanverth1, 2015-12-04 21:39:53]

I believe the usage for Chromium transfer buffers is correct -- I have an email
out to reveman@ to confirm.

[bsalomon, 2015-12-07 14:16:35]

lgtm

[jvanverth1, 2015-12-07 14:27:04]

https://codereview.chromium.org/1503593002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1503593002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:1716: static const GrGLbitfield kWriteAccess =
GR_GL_MAP_INVALIDATE_BUFFER_BIT |
I realized over the weekend that I need to fix this for the glyph atlas --
otherwise you can write some data into the buffer, transfer it, then try to
write some more and end up invalidating it. But that will be in the next change.

[jvanverth1, 2015-12-07 14:27:20]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2015-12-07 14:27:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503593002/1

[commit-bot: I haz the power, 2015-12-07 14:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 14:28:31]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[jvanverth1, 2015-12-07 15:24:02]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-12-07 15:24:02]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1503593002/#ps20001
(title: "Fix compile errors")

[commit-bot: I haz the power, 2015-12-07 15:24:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503593002/20001

[commit-bot: I haz the power, 2015-12-07 15:36:47]

Description was changed from

==========
Add transfer buffer to GLCaps

Adds a check for PBO/transfer buffer support to GrGLCaps,
and uses that to pick the correct buffer type.

BUG=skia:4604
==========

to

==========
Add transfer buffer to GLCaps

Adds a check for PBO/transfer buffer support to GrGLCaps,
and uses that to pick the correct buffer type.

BUG=skia:4604

Committed:
https://skia.googlesource.com/skia/+/d7a2c1f5fd710581d6233de5c202d3f2627948e0
==========

[commit-bot: I haz the power, 2015-12-07 15:36:49]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d7a2c1f5fd710581d6233de5c202d3f2627948e0