Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1503583003: Remove C-Style casts in severl other fwl_...imp.cpp files (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Remove C-Style casts in severl other fwl_...imp.cpp files Uncovered bad casts in a couple of places, replaced with correct objects. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a52feb072872f42b76994c5b5b5ba467d1103b7b

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -204 lines) Patch
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 11 chunks +13 lines, -13 lines 2 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 18 chunks +41 lines, -36 lines 1 comment Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 28 chunks +63 lines, -39 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 11 chunks +68 lines, -67 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 2 chunks +11 lines, -9 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 8 chunks +11 lines, -9 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 4 chunks +10 lines, -8 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fxmath_barcodeimp.cpp View 8 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1503583003/diff/1/xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp File xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp (right): https://codereview.chromium.org/1503583003/diff/1/xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp#newcode869 xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp:869: propEdit.m_pParent = m_pInterface; yow. https://codereview.chromium.org/1503583003/diff/1/xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp#newcode961 xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp:961: ...
5 years ago (2015-12-05 00:30:26 UTC) #2
Lei Zhang
lgtm
5 years ago (2015-12-05 01:38:36 UTC) #3
Tom Sepez
5 years ago (2015-12-07 17:07:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a52feb072872f42b76994c5b5b5ba467d1103b7b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698