chrome/browser/ui/views/frame/browser_view.cc - Issue 1503583002: [Extensions Views] Update the extension installed bubble's sync promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1503583002: [Extensions Views] Update the extension installed bubble's sync promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('K') | « chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('k') | chrome/browser/ui/views/sync/bubble_sync_promo_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index e91be84565c4b0689e842a0812d7d82627aa695c..17acdbc0a23c71b9a203274c63e38aaa701d9465 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -42,7 +42,6 @@

#include "chrome/browser/translate/chrome_translate_client.h"

#include "chrome/browser/ui/ash/ash_util.h"

#include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"

-#include "chrome/browser/ui/bookmarks/bookmark_bubble_delegate.h"

#include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_command_controller.h"

@@ -54,6 +53,7 @@

#include "chrome/browser/ui/search/search_delegate.h"

#include "chrome/browser/ui/search/search_model.h"

#include "chrome/browser/ui/search/search_ui.h"

+#include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"

#include "chrome/browser/ui/tabs/tab_menu_model.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/browser/ui/view_ids.h"

@@ -1293,7 +1293,7 @@ void BrowserView::ShowUpdateChromeDialog() {

}

void BrowserView::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) {

- scoped_ptr<BookmarkBubbleDelegate> delegate;

+ scoped_ptr<BubbleSyncPromoDelegate> delegate;

delegate.reset(new BookmarkBubbleSignInDelegate(browser_.get()));

BookmarkBubbleView::ShowBubble(GetToolbarView()->GetBookmarkBubbleAnchor(),