chrome/browser/media/desktop_streams_registry.cc - Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/desktop_streams_registry.cc

Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review round 4 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/desktop_streams_registry.cc

diff --git a/chrome/browser/media/desktop_streams_registry.cc b/chrome/browser/media/desktop_streams_registry.cc

index bd21240cdc56f3117fc2fe2f0a1e2052ef5cd7cd..cb1708ff82520c5f0d765cad69c6b4b81b38fe5f 100644

--- a/chrome/browser/media/desktop_streams_registry.cc

+++ b/chrome/browser/media/desktop_streams_registry.cc

@@ -39,6 +39,7 @@ std::string DesktopStreamsRegistry::RegisterStream(

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

std::string id = GenerateRandomStreamId();

qiangchen 2015/12/16 21:08:36 We can remove this line, and then remove this file

GeorgeZ 2015/12/16 22:38:40 Done.

DCHECK(approved_streams_.find(id) == approved_streams_.end());

ApprovedDesktopMediaStream& stream = approved_streams_[id];

stream.render_process_id = render_process_id;