chrome/common/extensions/docs/examples/api/desktopCapture/app.js - Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/api/desktopCapture/app.js

Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review round 3 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/examples/api/desktopCapture/app.js

diff --git a/chrome/common/extensions/docs/examples/api/desktopCapture/app.js b/chrome/common/extensions/docs/examples/api/desktopCapture/app.js

index 65823afc529c45cfad0aa18dc53de7625ef4bf2a..92577408882ad98696d701cf375ee804a69453bf 100644

--- a/chrome/common/extensions/docs/examples/api/desktopCapture/app.js

+++ b/chrome/common/extensions/docs/examples/api/desktopCapture/app.js

@@ -4,7 +4,7 @@

'use strict';

-const DESKTOP_MEDIA = ['screen', 'window'];

+const DESKTOP_MEDIA = ['screen', 'window', "tab"];

Ken Rockot(use gerrit already) 2015/12/15 00:06:16 nit: Please keep quote styles consistent

GeorgeZ 2015/12/16 00:07:39 Done.

var pending_request_id = null;

var pc1 = null;