Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/browser/ui/views/desktop_media_picker_views.cc

Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/desktop_media_picker_views.cc
diff --git a/chrome/browser/ui/views/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_media_picker_views.cc
index 1c89f35c3111bef1979e766d7532d03ac60b5733..f40d69f631955b1fda141178f65a3e0ea30beec7 100644
--- a/chrome/browser/ui/views/desktop_media_picker_views.cc
+++ b/chrome/browser/ui/views/desktop_media_picker_views.cc
@@ -523,7 +523,8 @@ bool DesktopMediaPickerDialogView::Accept() {
if (selection)
source = selection->source_id();
- if (parent_)
+ // Temporarily disable tab capture. This will be enabled later.
Avi (use Gerrit) 2016/01/11 16:27:57 "enabled later" meaning: 1) It's in the code, and
GeorgeZ 2016/01/11 19:16:19 It is 2. Therefore I use TODO.
+ if (parent_ && source.type != DesktopMediaID::TYPE_TAB)
parent_->NotifyDialogResult(source);
// Return true to close the window.

Powered by Google App Engine
This is Rietveld 408576698