chrome/browser/media/desktop_media_list.h - Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia() - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1409)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/browser/media/desktop_media_list.h

Issue 1503563004: Desktop chrome tab capture-chooseDesktopMedia() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review round 1 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc ('k') | chrome/browser/media/desktop_media_list.cc » ('j') | chrome/browser/media/desktop_media_list.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/desktop_media_list.h

diff --git a/chrome/browser/media/desktop_media_list.h b/chrome/browser/media/desktop_media_list.h

index d8b2e237f343cd13b8b39c5bfa21605329315296..e10778523838bf65e679c2e5afd04f47a6954aff 100644

--- a/chrome/browser/media/desktop_media_list.h

+++ b/chrome/browser/media/desktop_media_list.h

@@ -9,6 +9,7 @@

#include "base/strings/string16.h"

#include "base/time/time.h"

#include "content/public/browser/desktop_media_id.h"

+#include "ui/gfx/image/image.h"

#include "ui/gfx/image/image_skia.h"

class DesktopMediaListObserver;

@@ -56,6 +57,13 @@ class DesktopMediaList {

virtual int GetSourceCount() const = 0;

virtual const Source& GetSource(int index) const = 0;

+

+ protected:

+ // Create a image with an enlarged favicon on its center and black boundary.

+ // If fails, an empty image will return.

+ // The function is used to create a thumbnail for chrome tab preview.

+ static gfx::ImageSkia CreateImageEncloseFavicon(gfx::Size size,

miu 2015/12/12 00:00:33 naming nit: How about: CreateEnlargedFaviconImage(

+ gfx::Image& favicon);

};

#endif // CHROME_BROWSER_MEDIA_DESKTOP_MEDIA_LIST_H_

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc ('k') | chrome/browser/media/desktop_media_list.cc » ('j') | chrome/browser/media/desktop_media_list.cc » ('J')

Powered by Google App Engine

This is Rietveld 408576698