Desktop chrome tab capture-chooseDesktopMedia()

chrome/browser/media/desktop_media_list.h

Index: chrome/browser/media/desktop_media_list.h
diff --git a/chrome/browser/media/desktop_media_list.h b/chrome/browser/media/desktop_media_list.h
index d8b2e237f343cd13b8b39c5bfa21605329315296..ebfd983e3a2f257a2222ea20cae671fc4de95ada 100644
--- a/chrome/browser/media/desktop_media_list.h
+++ b/chrome/browser/media/desktop_media_list.h
@@ -9,6 +9,7 @@
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "content/public/browser/desktop_media_id.h"
+#include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 
 class DesktopMediaListObserver;
@@ -56,6 +57,13 @@ class DesktopMediaList {
 
   virtual int GetSourceCount() const = 0;
   virtual const Source& GetSource(int index) const = 0;
+
+ protected:
+  // Create a image with an enlarged favicon on its center and black boundary.
+  // If fails, an empty image will return.
+  // The function is used to create a thumbnail for chrome tab preview.

[mark a. foltz, 2016/01/04 20:11:40]

There is already an API to generate tab thumbnails, see

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...

Is there a reason to add a second one here, or at a minimum can the
implementation be shared?

[GeorgeZ, 2016/01/06 22:41:39]

The code you mentioned is to capture visible area of an active tab/Webcontents.
In our case, most tabs are inactive and invisible. Inactive tabs may not be
loaded and loading them will be cost. Therefore, we use a favicon as the
thumbnail instead of actually loading and capturing the previous of a tab.

+  static gfx::ImageSkia CreateEnlargedFaviconImage(gfx::Size size,

[Sergey Ulanov, 2015/12/18 19:45:04]

I don't think this is the right place for this function.
This is an abstract interface. It shouldn't have any methods, even protected
static.

[GeorgeZ, 2015/12/18 21:57:26]

I will move this function away from here.

[GeorgeZ, 2016/01/06 22:41:39]

Done.

+                                                   gfx::Image& favicon);
 };
 
 #endif  // CHROME_BROWSER_MEDIA_DESKTOP_MEDIA_LIST_H_