Desktop chrome tab capture-chooseDesktopMedia()

chrome/browser/media/native_desktop_media_list_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/native_desktop_media_list.h"
 
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 131 matching lines @@
   DesktopMediaListTest()
       : window_capturer_(NULL),
         ui_thread_(content::BrowserThread::UI,
                    &message_loop_) {
   }
 
   void CreateWithDefaultCapturers() {
     window_capturer_ = new FakeWindowCapturer();
     model_.reset(new NativeDesktopMediaList(
         scoped_ptr<webrtc::ScreenCapturer>(new FakeScreenCapturer()),
-        scoped_ptr<webrtc::WindowCapturer>(window_capturer_)));
+        scoped_ptr<webrtc::WindowCapturer>(window_capturer_), false));
 
     // Set update period to reduce the time it takes to run tests.
     model_->SetUpdatePeriod(base::TimeDelta::FromMilliseconds(0));
   }
 
   webrtc::WindowCapturer::WindowList AddWindowsAndVerify(
       size_t count, bool window_only) {
     webrtc::WindowCapturer::WindowList list;
     for (size_t i = 0; i < count; ++i) {
       webrtc::WindowCapturer::Window window;
@@ skipping 61 matching lines @@
   webrtc::WindowCapturer::WindowList list = AddWindowsAndVerify(2, false);
 
   EXPECT_EQ(model_->GetSource(0).id.type, content::DesktopMediaID::TYPE_SCREEN);
   EXPECT_EQ(model_->GetSource(0).id.id, 0);
 }
 
 TEST_F(DesktopMediaListTest, WindowsOnly) {
   window_capturer_ = new FakeWindowCapturer();
   model_.reset(new NativeDesktopMediaList(
       scoped_ptr<webrtc::ScreenCapturer>(),
-      scoped_ptr<webrtc::WindowCapturer>(window_capturer_)));
+      scoped_ptr<webrtc::WindowCapturer>(window_capturer_), false));
   AddWindowsAndVerify(1, true);
 }
 
 TEST_F(DesktopMediaListTest, ScreenOnly) {
   model_.reset(new NativeDesktopMediaList(
       scoped_ptr<webrtc::ScreenCapturer>(new FakeScreenCapturer),
-      scoped_ptr<webrtc::WindowCapturer>()));
+      scoped_ptr<webrtc::WindowCapturer>(), false));

[qiangchen, 2015/12/07 22:45:56]

Consider adding a test case say "TabOnly"

[GeorgeZ, 2015/12/09 19:36:38]

Need modify unit tests desktop_meida_list_ash_uninttest.cc and
native_desktop_meida_list_uninttest.cc and associated desktop_meida_list_ash.cc
and native_desktop_meida_list.cc to cover tab cases.

How about that I create another CL to cover units test to limit the scope of
this CL?

 
   {
     testing::InSequence dummy;
     EXPECT_CALL(observer_, OnSourceAdded(0))
       .WillOnce(CheckListSize(model_.get(), 1));
     EXPECT_CALL(observer_, OnSourceThumbnailChanged(0))
       .WillOnce(QuitMessageLoop(&message_loop_));
   }
   model_->StartUpdating(&observer_);
 
@@ skipping 93 matching lines @@
   // Swap the two windows.
   webrtc::WindowCapturer::Window temp = list[0];
   list[0] = list[1];
   list[1] = temp;
   window_capturer_->SetWindowList(list);
 
   message_loop_.Run();
 }
 
 }  // namespace