Desktop chrome tab capture-chooseDesktopMedia()

chrome/browser/media/desktop_streams_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/desktop_streams_registry.h"
 
 #include "base/base64.h"
 #include "base/location.h"
 #include "base/time/time.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 21 matching lines @@
 
 std::string DesktopStreamsRegistry::RegisterStream(
     int render_process_id,
     int render_frame_id,
     const GURL& origin,
     const content::DesktopMediaID& source,
     const std::string& extension_name) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   std::string id = GenerateRandomStreamId();
+
+  // Give the ability of identify tab type from id.
+  if (source.type == content::DesktopMediaID::TYPE_TAB)
+    id = source.ToString();

[miu, 2015/12/08 01:54:38]

This is a security violation.  If you need this information, please add it to
the ApprovedDesktopMediaStream struct.

[GeorgeZ, 2015/12/09 19:36:37]

I will remove this one. I remembered this change is not definite needed. It is
just better to have. if I am wrong, I will figure it out in the next CL that is
going to hook up webcontentscapture.

+
   DCHECK(approved_streams_.find(id) == approved_streams_.end());
   ApprovedDesktopMediaStream& stream = approved_streams_[id];
   stream.render_process_id = render_process_id;
   stream.render_frame_id = render_frame_id;
   stream.origin = origin;
   stream.source = source;
   stream.extension_name = extension_name;
 
   content::BrowserThread::PostDelayedTask(
       content::BrowserThread::UI, FROM_HERE,
@@ skipping 29 matching lines @@
   return result;
 }
 
 void DesktopStreamsRegistry::CleanupStream(const std::string& id) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   approved_streams_.erase(id);
 }
 
 DesktopStreamsRegistry::ApprovedDesktopMediaStream::ApprovedDesktopMediaStream()
     : render_process_id(-1), render_frame_id(-1) {}