Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: xfa/src/fwl/src/core/include/fwl_threadimp.h

Issue 1503503003: Rename CFWL_Thread classes to ThreadImp (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fwl/src/core/include/fwl_threadimp.h
diff --git a/xfa/src/fwl/src/core/include/fwl_threadimp.h b/xfa/src/fwl/src/core/include/fwl_threadimp.h
index eb3331f4518a719fed723dfa964aed505cfd927b..644f6a36786cf358eec3dc25a3c6a0d79f9b55fe 100644
--- a/xfa/src/fwl/src/core/include/fwl_threadimp.h
+++ b/xfa/src/fwl/src/core/include/fwl_threadimp.h
@@ -4,31 +4,32 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#ifndef _FWL_THREAD_IMP_H
-#define _FWL_THREAD_IMP_H
+#ifndef FWL_THREADIMP_H_
+#define FWL_THREADIMP_H_
#include "xfa/include/fwl/core/fwl_thread.h" // For FWL_HTHREAD.
class CFWL_NoteDriver;
class IFWL_NoteDriver;
-class CFWL_Thread {
+class CFWL_ThreadImp {
Lei Zhang 2015/12/05 01:00:34 Are you going to inherit from IFWL_Thread in a dif
public:
- CFWL_Thread();
- virtual ~CFWL_Thread();
- virtual void Release() { delete this; }
Lei Zhang 2015/12/05 01:00:34 IFWL_Thread has a Release(), BTW.
+ CFWL_ThreadImp();
+ virtual ~CFWL_ThreadImp();
+
virtual FWL_ERR Run(FWL_HTHREAD hThread);
};
-class CFWL_NoteThread : public CFWL_Thread {
+class CFWL_NoteThreadImp : public CFWL_ThreadImp {
public:
- CFWL_NoteThread();
- virtual ~CFWL_NoteThread();
- virtual FWL_ERR Run(FWL_HTHREAD hThread);
+ CFWL_NoteThreadImp();
+ virtual ~CFWL_NoteThreadImp();
+
+ FWL_ERR Run(FWL_HTHREAD hThread) override;
virtual IFWL_NoteDriver* GetNoteDriver();
protected:
CFWL_NoteDriver* m_pNoteDriver;
- FWL_HTHREAD m_hThread;
};
-#endif
+
+#endif // FWL_THREADIMP_H_

Powered by Google App Engine
This is Rietveld 408576698