Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503503003: Rename CFWL_Thread classes to ThreadImp (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Rename CFWL_Thread classes to ThreadImp This matches the 3-level parallel hierarchy convention used elsewhere in FWL. Remove dead code along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6fa20c60c6ed551af55bfc879668eaac5c237805

Patch Set 1 #

Total comments: 3

Patch Set 2 : Duplicate pure virtual method #

Total comments: 3

Patch Set 3 : Remove if {}, delete unused methods. #

Patch Set 4 : Stray semicolon. #

Patch Set 5 : Remove one more dead class. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -180 lines) Patch
M xfa/include/fwl/adapter/fwl_adapterthreadmgr.h View 1 2 3 4 2 chunks +4 lines, -15 lines 0 comments Download
M xfa/include/fwl/core/fwl_thread.h View 1 2 1 chunk +10 lines, -32 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_threadimp.cpp View 1 2 3 1 chunk +9 lines, -106 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_appimp.h View 2 chunks +9 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_noteimp.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/core/include/fwl_threadimp.h View 1 chunk +13 lines, -12 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_widgetimp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Tom Sepez
Lei, next part of making things smaller. https://codereview.chromium.org/1503503003/diff/1/xfa/src/fwl/src/core/fwl_threadimp.cpp File xfa/src/fwl/src/core/fwl_threadimp.cpp (right): https://codereview.chromium.org/1503503003/diff/1/xfa/src/fwl/src/core/fwl_threadimp.cpp#newcode13 xfa/src/fwl/src/core/fwl_threadimp.cpp:13: return (IFWL_Thread*)new ...
5 years ago (2015-12-05 00:19:29 UTC) #2
Lei Zhang
https://codereview.chromium.org/1503503003/diff/1/xfa/src/fwl/src/core/include/fwl_threadimp.h File xfa/src/fwl/src/core/include/fwl_threadimp.h (left): https://codereview.chromium.org/1503503003/diff/1/xfa/src/fwl/src/core/include/fwl_threadimp.h#oldcode19 xfa/src/fwl/src/core/include/fwl_threadimp.h:19: virtual void Release() { delete this; } IFWL_Thread has ...
5 years ago (2015-12-05 01:00:35 UTC) #3
Lei Zhang
https://codereview.chromium.org/1503503003/diff/20001/xfa/src/fwl/src/core/fwl_threadimp.cpp File xfa/src/fwl/src/core/fwl_threadimp.cpp (right): https://codereview.chromium.org/1503503003/diff/20001/xfa/src/fwl/src/core/fwl_threadimp.cpp#newcode27 xfa/src/fwl/src/core/fwl_threadimp.cpp:27: if (m_pNoteDriver) { delete this if too?
5 years ago (2015-12-05 01:01:04 UTC) #4
Tom Sepez
https://codereview.chromium.org/1503503003/diff/20001/xfa/src/fwl/src/core/fwl_threadimp.cpp File xfa/src/fwl/src/core/fwl_threadimp.cpp (right): https://codereview.chromium.org/1503503003/diff/20001/xfa/src/fwl/src/core/fwl_threadimp.cpp#newcode12 xfa/src/fwl/src/core/fwl_threadimp.cpp:12: IFWL_Thread* IFWL_Thread::Create() { Also, this is never called. https://codereview.chromium.org/1503503003/diff/20001/xfa/src/fwl/src/core/fwl_threadimp.cpp#newcode27 ...
5 years ago (2015-12-07 17:21:46 UTC) #5
Tom Sepez
> Are you going to inherit from IFWL_Thread in a different CL? Either that, or ...
5 years ago (2015-12-07 17:22:46 UTC) #6
Tom Sepez
Lei, please take a look. I removed one more dead class. Thanks.
5 years ago (2015-12-07 17:32:31 UTC) #7
Lei Zhang
lgtm
5 years ago (2015-12-07 19:38:00 UTC) #8
Tom Sepez
5 years ago (2015-12-07 20:21:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
6fa20c60c6ed551af55bfc879668eaac5c237805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698