move combinator contributor to new task model

move combinator contributor to new task model

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a5e4c81b7f0027ec632e02f83340763ef383cd0d

[danrubel, 2015-12-04 14:43:09]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-12-04 17:43:26]

lgtm

https://codereview.chromium.org/1503463002/diff/20001/pkg/analysis_server/lib...
File
pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart
(right):

https://codereview.chromium.org/1503463002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart:30:
CompilationUnit unit = await request.resolveDeclarationsInScope();
It seems too wide.
It would be enough to get LIBRARY_ELEMENT4 for the directive's source.

[danrubel, 2015-12-04 20:46:22]

https://codereview.chromium.org/1503463002/diff/20001/pkg/analysis_server/lib...
File
pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart
(right):

https://codereview.chromium.org/1503463002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart:30:
CompilationUnit unit = await request.resolveDeclarationsInScope();
On 2015/12/04 17:43:26, scheglov wrote:
> It seems too wide.
> It would be enough to get LIBRARY_ELEMENT4 for the directive's source.

Thanks for the info. I'll address this in the next CL.

[danrubel, 2015-12-04 20:48:28]

Description was changed from

==========
move combinator contributor to new task model
==========

to

==========
move combinator contributor to new task model

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a5e4c81b7f0027ec632e02f83340763ef383cd0d
==========

[danrubel, 2015-12-04 20:48:29]

Committed patchset #2 (id:20001) manually as
a5e4c81b7f0027ec632e02f83340763ef383cd0d (presubmit successful).