src/effects/gradients/SkClampRange.h - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkClampRange.h

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix typo Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkClampRange.h

diff --git a/src/effects/gradients/SkClampRange.h b/src/effects/gradients/SkClampRange.h

index 945f9a7ff18311890ff2b58fad1ecd1cee0bc5f6..d3d2d08c86d8a38861a24e3ba009dfa32cf1f8dd 100644

--- a/src/effects/gradients/SkClampRange.h

+++ b/src/effects/gradients/SkClampRange.h

@@ -12,8 +12,8 @@

#include "SkScalar.h"

#define SkGradFixed SkFixed3232

-#define SkScalarToGradFixed SkScalarToFixed3232

-#define SkFixedToGradFixed SkFixedToFixed3232

+#define SkScalarToGradFixed(x) SkScalarToFixed3232(x)

reed1 2015/12/09 15:54:27 nice catch

mtklein 2015/12/09 16:48:11 has this actually changed anything? just hygiene?

caryclark 2015/12/09 19:13:12 No change -- made it while tracking down a differe

+#define SkFixedToGradFixed(x) SkFixedToFixed3232(x)

#define SkGradFixedToFixed(x) (SkFixed)((x) >> 16)

#define kFracMax_SkGradFixed 0xFFFFFFFFLL