tests/RandomTest.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RandomTest.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add cast to work around win compiler Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/RandomTest.cpp

diff --git a/tests/RandomTest.cpp b/tests/RandomTest.cpp

index 8d93d87df6cd7fafbfc11630244b7865217bb580..448f07340f41bbf488ac81246871377677a6f407 100644

--- a/tests/RandomTest.cpp

+++ b/tests/RandomTest.cpp

@@ -119,7 +119,7 @@ static double test_single_gorilla(skiatest::Reporter* reporter, int shift) {

// now make some strings and track them

for (int i = 0; i < kN; ++i) {

- value <<= 1;

+ value = SkLeftShift(value, 1);

unsigned int rnd = rand.nextU();

value |= ((rnd >> shift) & 0x1);

« no previous file with comments | « tests/MathTest.cpp ('k') | no next file » | no next file with comments »